[PATCH] D34966: [WebAssembly] Fix types for address taken functions

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 5 11:41:53 PDT 2017


dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.

LGTM with a nit. In the summary, did you mean that we were *not* setting their params and return types?



================
Comment at: lib/Target/WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.cpp:270
+
+  SmallVector<wasm::ValType, 4> ValResults;
+  for (MVT Ty : Results)
----------------
Might as well make this a smallvector of size 1.


https://reviews.llvm.org/D34966





More information about the llvm-commits mailing list