[PATCH] D34734: [WebAssembly] MC: Don't generate extra types for weak alias

[Derek Schuff via Phabricator via llvm-commits]

dschuff accepted this revision.
dschuff added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/MC/WasmObjectWriter.cpp:962
   for (const MCSymbol &S : Asm.symbols()) {
+    if (S.isVariable())
+      continue;
----------------
sbc100 wrote:
> dschuff wrote:
> > so a weak alias both `isVariable()` and `isFunction()`?
> Yup
That's.... fun. Maybe should add a comment here about that.


https://reviews.llvm.org/D34734