[PATCH] D34736: [cmake] Cache results of find_darwin_sdk_dir and add an option to prefer public SDK

[George Karpenkov via Phabricator via llvm-commits]

george.karpenkov added inline comments.


================
Comment at: cmake/Modules/CompilerRTDarwinUtils.cmake:11
+  endif()
+  set(DARWIN_PREFER_PUBLIC_SDK OFF CACHE BOOL "Prefer Darwin public SDK, even when an internal SDK is present.")
+  if(NOT DARWIN_PREFER_PUBLIC_SDK)
----------------
Could you move this change to a separate review and additionally move the variable declaration outside of the function?


================
Comment at: cmake/Modules/CompilerRTDarwinUtils.cmake:36
   endif()
+  set(DARWIN_${sdk_name}_CACHED_SYSROOT ${var_internal} CACHE STRING "Darwin SDK path for SDK ${sdk_name}.")
 endfunction()
----------------
Can we move the declaration to top of the file, and then use `FORCE` to set it at the end of the function?


Repository:
  rL LLVM

https://reviews.llvm.org/D34736