[PATCH] D35005: [ELF] - Do not apply relocations to .debug_ranges when building -gdb-index
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 5 10:06:59 PDT 2017
dblaikie added inline comments.
================
Comment at: ELF/SyntheticSections.cpp:1821-1822
+ return false;
+ if (S == ".rela.debug_ranges" || S == ".rel.debug_ranges")
+ return relocateDebugRanges(RelSec, Map);
+ return false;
----------------
Any particular reason this would only be done for ranges sections and not for other sections?
================
Comment at: ELF/SyntheticSections.cpp:1851
+
+ return true;
+ }
----------------
This function always returns true, so may be better off having void return instead. The return value doesn't seem to be communicating anything.
https://reviews.llvm.org/D35005
More information about the llvm-commits
mailing list