[PATCH] D35001: [LNT] Missing "Produced by" field on Run causes UI to crash
Kristof Beyls via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 5 08:49:04 PDT 2017
kristof.beyls added inline comments.
================
Comment at: tests/server/ui/V4Pages.py:291-292
+ # Get a run that contains producer information
+ check_code(client, '/v4/nts/7')
+
----------------
Ideally, the test would also check that the outputted producer information is as expected, not just that the HTML return code is as expected.
You can find examples of how that's done in this file; just look for how check_nr_machines_reported is used & defined. check_table_content is another example.
Do you think it would be possible to improve the test case like this without too much effort?
https://reviews.llvm.org/D35001
More information about the llvm-commits
mailing list