[PATCH] D33764: [globalisel][tablegen] Added instruction emission to the state-machine-based matcher.

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 5 03:11:27 PDT 2017


dsanders added inline comments.


================
Comment at: test/TableGen/GlobalISelEmitter.td:110
 // CHECK-NEXT:  MIs.push_back(&I);
+// CHECK-NEXT:  DEBUG(dbgs() << "Processing MatchTable0\n");
 // CHECK-NEXT:  if (executeMatchTable(*this, State, MatcherInfo, MatchTable0, MRI, TRI, RBI, AvailableFeatures)) {
----------------
chapuni wrote:
> Does it require "REQUIRES: asserts" ?
No, this test doesn't actually execute the statement. It just checks that tablegen emits it.

There is an asserts issue elsewhere that I'm fixing at the moment though. The various release-mode buildbots are complaining about an unused variable.


https://reviews.llvm.org/D33764





More information about the llvm-commits mailing list