[PATCH] D28907: [SLP] Fix for PR30787: Failure to beneficially vectorize 'copyable' elements in integer binary ops.

Dinar Temirbulatov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 4 17:59:00 PDT 2017


dtemirbulatov added inline comments.


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:3265
+    // No need to handle users of gathered values.
+    if (Entry->NeedToGather)
+      continue;
----------------
RKSimon wrote:
> Can this (and the assert below) be pulled out of the inner loop as an NFC commit now? It looks loop invariant.
hmm, Entry is updating on every cycle above.


https://reviews.llvm.org/D28907





More information about the llvm-commits mailing list