[PATCH] D34652: [x86] add SBB optimization for SETAE (uge) condition code

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In https://reviews.llvm.org/D34652#798894, @zvi wrote:

> LGTM. Internal testing did not reveal any performance impact for better or worse. Thanks.


Thanks for checking! FWIW, this patch increases the likelihood of producing the sbb. However, if a 'naked sbb' is a problem, then I think that pattern already exists anytime we create X86ISD::SETCC_CARRY directly or with materializeSBB(). So we should have the fixup pass independent of this patch assuming that the false dependency stall is a problem.


https://reviews.llvm.org/D34652