[PATCH] D34855: [lit] Factor out listdir logic shared by different test formats.

Tue Jul 4 00:53:32 PDT 2017

andrewng added a comment.

In https://reviews.llvm.org/D34855#798200, @grimar wrote:

> Ah, I just noticed the https://reviews.llvm.org/D34853, it fixes the issue I am observing.

Hi,

I have also hit this issue. I don't think that https://reviews.llvm.org/D34853 is the correct solution (see my comment in that review).

I think the easiest fix (and it's the workaround I currently have in place) is to test that the directory exists in GoogleTest.getTestsInDirectory before calling lit.util.listdir_files. I will put together a patch and review for this fix.

Cheers,
Andrew

Repository:
  rL LLVM

https://reviews.llvm.org/D34855