[PATCH] D34978: [GlobalIsel] fix undefined behavior if Action not set.

Kristof Beyls via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 4 04:55:34 PDT 2017


kristof.beyls added a comment.

Hi Igor,

Would it be possible to add a regression test for this?
I'm wondering when this fails today. I guess it must be when the target has specified an action for e.g. TypeIdx 0, but not TypeIdx 1?
I'm just trying to understand if this should be an assert (if a target hasn't specified something fully enough) or an if statement.

Thanks,

Kristof


https://reviews.llvm.org/D34978





More information about the llvm-commits mailing list