[PATCH] D34876: [asan] Remove check for stack size

Aleksey Shlyapnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 3 09:48:27 PDT 2017


alekseyshl accepted this revision.
alekseyshl added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D34876#797665, @Hahnfeld wrote:

> In https://reviews.llvm.org/D34876#796951, @alekseyshl wrote:
>
> > What's the stack size on CentOS? What was the point of the original check?
>
>
> The error is as follows:
>
>   "((stack_size)) <= ((0x10000000))" (0x40000000, 0x10000000)
>
>
> Please note that I have `ulimit -s unlimited` because I often had problems with Fortran applications that required large stack sizes. With `ulimit -s 4096`, the problem also goes away.
>  However, I don't understand this check either, so I'd say to remove it as it causes problems.


I'm ok with removing this check, we can always bring it back (with proper comment this time).

Kostya, what exactly this check was for?


https://reviews.llvm.org/D34876





More information about the llvm-commits mailing list