[lld] r306813 - [ELF] - Resolve references properly when using .symver directive
Rafael Avila de Espindola via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 3 08:30:01 PDT 2017
George Rimar <grimar at accesssoftek.com> writes:
>> Reverted in r306996.?
>
>
> Ed, thanks for reproduce !
>
>
> Rui, thanks for reverting. I found fix is one line trivial for this:
>
>
> if (Config->Shared) // This line should be added.
> error(toString(File) + ": symbol " + S + " has undefined version " +
> Verstr);
>
> We had this chyeck in one of latest diffs during review but it was removed in final patch version,
> I think we need to restore it.
>
> reviews.llvm.org<https://reviews.llvm.org/> is currently unavailable for everyone (it seems for about a day atm),
> I'll update the patch with this change and trigger "needs review" again as soon as it be alive.
Just send the patch in an email.
Cheers,
Rafael
More information about the llvm-commits
mailing list