[PATCH] D34855: [lit] Factor out listdir logic shared by different test formats.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

Hi !

This (r306895) causes check-lld failtures under windows for me:

  24>  Traceback (most recent call last):
  24>    File "C:/access_softek/llvm/utils/lit/lit.py", line 6, in <module>
  24>      main()
  24>    File "C:\access_softek\llvm\utils\lit\lit\main.py", line 161, in main
  24>      main_with_tmp(builtinParameters)
  24>    File "C:\access_softek\llvm\utils\lit\lit\main.py", line 344, in main_with_tmp
  24>      lit.discovery.find_tests_for_inputs(litConfig, inputs))
  24>    File "C:\access_softek\llvm\utils\lit\lit\discovery.py", line 222, in find_tests_for_inputs
  24>      test_suite_cache, local_config_cache)[1])
  24>    File "C:\access_softek\llvm\utils\lit\lit\discovery.py", line 186, in getTestsInSuite
  24>      for res in subiter:
  24>    File "C:\access_softek\llvm\utils\lit\lit\discovery.py", line 144, in getTestsInSuite
  24>      litConfig, lc):
  24>    File "C:\access_softek\llvm\utils\lit\lit\formats\googletest.py", line 85, in getTestsInDirectory
  24>      suffixes={self.test_suffix}):
  24>    File "C:\access_softek\llvm\utils\lit\lit\util.py", line 136, in listdir_files
  24>      for filename in os.listdir(dirname):
  24>  WindowsError: [Error 3] : 'C:\\access_softek\\c_make_build_dir_x64\\tools\\lld\\unittests\\debug/*.*'

I think issue is that C:\\access_softek\\c_make_build_dir_x64\\tools\\lld\\unittests\\debug folder not exist.
I added some traces (https://reviews.llvm.org/D34944) and compared output from windows and ubuntu runs of check-lld:
(under ubuntu it works fine)

Ubuntu:

  /home/umb/LLVM/llvm/tools/lld/test
  Subdirs: .
  BuildMode: .
  Source: /home/umb/LLVM/llvm-build/tools/lld/unittests
  Subdir: .
  /home/umb/LLVM/llvm-build/tools/lld/unittests/.

Windows:

  24>  BuildMode: Debug
  24>  Subdirs: Debug
  24>  Source: C:\access_softek\c_make_build_dir_x64\tools\lld\unittests
  24>  Subdir: debug
  24>  Dirname: C:\access_softek\c_make_build_dir_x64\tools\lld\unittests\debug

So looks in my windows case config.llvm_build_mode is added to the path and that is the reason of failture.
Not sure why Buildmode is "." under ubuntu though and where it comes from.


Repository:
  rL LLVM

https://reviews.llvm.org/D34855