[PATCH] D34917: ELF: Only unlink regular files

[Rafael Avila de Espindola via llvm-commits]

Rafael Avila de Espindola <rafael.espindola at gmail.com> writes:

> LGTM
>
> FileOutputBuffer has something similar, so this is all that we have to
> do.
>
> It is a pity that we have to unlink at all. I will do a quick benchmark
> to see if rename without unlink is still slow.

There doesn't seem to be any way of avoiding the cost.

What I tried was

* Renaming without unlink: the rename is slow.
* Opening the file. This makes rename/unlink fast, but close is slow.
* Not calling close, the process exit is slow.

Cheers,
Rafael