[PATCH] D34898: [PDB] Fill in "Parent" and "End" fields of scope-like symbol records

[Zachary Turner via Phabricator via llvm-commits]

zturner added a comment.

Did the new patch not get uploaded?  I'm still seeing the original patch.



================
Comment at: lld/COFF/PDB.cpp:223
+                           uint32_t CurOffset,
+                           MutableArrayRef<uint8_t> Contents) {
+  SymbolScope S;
----------------
rnk wrote:
> zturner wrote:
> > Can you change the signature to
> > 
> > ```
> > static void scopeStackOpen(SmallVectorImpl<SymbolScope> &Stack,
> >                            uint32_t Offset,
> >                            CVSymbol &BeginSymbol) {
> > ```
> > and then add an assert on line 1:
> > 
> > ```
> > assert(symbolOpensScope(BeginSymbol.kind()));
> > ```
> > 
> > Mostly just for readability.
> Sure, but then I have to add a const_cast.
Oh, yea nevermind then.


https://reviews.llvm.org/D34898