[llvm] r306916 - A little wordsmithing of dominator verification comments.

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 30 16:49:53 PDT 2017


Author: dannyb
Date: Fri Jun 30 16:49:53 2017
New Revision: 306916

URL: http://llvm.org/viewvc/llvm-project?rev=306916&view=rev
Log:
A little wordsmithing of dominator verification comments.

Modified:
    llvm/trunk/include/llvm/Support/GenericDomTreeConstruction.h

Modified: llvm/trunk/include/llvm/Support/GenericDomTreeConstruction.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/GenericDomTreeConstruction.h?rev=306916&r1=306915&r2=306916&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Support/GenericDomTreeConstruction.h (original)
+++ llvm/trunk/include/llvm/Support/GenericDomTreeConstruction.h Fri Jun 30 16:49:53 2017
@@ -335,12 +335,12 @@ struct SemiNCAInfo {
 
   // The easiest way to think of the parent property is that it's a requirement
   // of being a dominator.  Let's just take immediate dominators.  For PARENT to
-  // be an immediate dominator of CHILD, all paths must go through PARAENT
-  // before they hit CHILD.  This implies that if you were to cut PARENT out of
-  // the CFG, there should be no paths to CHILD that are reachable.  If there
-  // were, then you now have a path from PARENT to CHILD that goes around PARENT
-  // and still reaches the target node, which by definition, means PARENT can't
-  // be a dominator (let alone an immediate one).
+  // be an immediate dominator of CHILD, all paths in the CFG must go through
+  // PARENT before they hit CHILD.  This implies that if you were to cut PARENT
+  // out of the CFG, there should be no paths to CHILD that are reachable.  If
+  // there are, then you now have a path from PARENT to CHILD that goes around
+  // PARENT and still reaches CHILD, which by definition, means PARENT can't be
+  // a dominator of CHILD (let alone an immediate one).
 
   // The sibling property is similar.  It says that for each pair of sibling
   // nodes in the dominator tree (LEFT and RIGHT) , they must not dominate each




More information about the llvm-commits mailing list