[PATCH] D34667: [Demangler] [DO NOT SUBMIT] Initial patch for Microsoft demangler.

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:631
+  case 'G': return Volatile | Far;
+  case 'H': return Const | Volatile | Far;
+  default:
----------------
Support for restrict and unaligned got removed, it seems like?  See original comments about how to correctly support those.


================
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:666
+    return;
+  }
+
----------------
Here's a few more.

```
3A6  Reference to function
3P6   Rvalue Reference to Function
3P8  Pointer to Member Function
3AEAP8 Reference to Member Function Pointer
3$$QEAP8  Rvalue reference to member function pointer  (wtf?)
```

This is the second time I've seen this `3$$`, so we should probably figure out what it means (it occurred in the variable of type `nullptr_t` also.


https://reviews.llvm.org/D34667