[PATCH] D34910: Make LLVM_TARGETS_TO_BUILD=all build all targets

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 30 14:33:57 PDT 2017


MatzeB added a comment.

Changing the meaning of "all" to really mean all targets makes sense. But there is of course a fundamental discussion hidding here:

However I think we explicitely do NOT build the experimental targets in any of the E-Mailing buildbots. I think it is fair to leave the burden of updating the experimental targets to whoever maintains them. I do make sure that I do not break compilation of experimental targets when I make changes to the API. However I do not want to start debugging and updating even more tests. This is always a huge pita on architectures you don't know, have no simulators/documentation about, may just have bugs in the target specific code that are triggered by your changes etc.
To have an example: Let's say a valid CodeGen change produces slightly different code that hits a "Not Implemented Yet" assert in the experimental target, I don't wanna implement that just to keep the tests running. Even XFAILing the affected tests, filing PRs for them etc. is a big hassle.

We should leave that reponsibility with the maintainers of the experimental targets. Which means we should only have "silent" bots for the experimental targets, i.e. only the target maintainer gets E-Mails for failures and he is responsible for fixing them.


Repository:
  rL LLVM

https://reviews.llvm.org/D34910





More information about the llvm-commits mailing list