[PATCH] D34898: [PDB] Fill in "Parent" and "End" fields of scope-like symbol records

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: lld/COFF/PDB.cpp:191
+  case SymbolKind::S_THUNK32:
+  case SymbolKind::S_INLINESITE:
+    return true;
----------------
zturner wrote:
> I found a couple of additional symbols that I wonder if we need to handle.
> 
> From cvdump.h
> ```
>     // Separated code (from the compiler) support
>     S_SEPCODE       =  0x1132,
>     
>     // extended inline site information
>     S_INLINESITE2 = 0x115d,
> ```
> 
> We don't currently handle either of these and I've never seen a problem, but maybe you have some theories on why they might arise?
> 
> Also, if we're not supporting code (we aren't), then might as well delete `S_WITH32`.  Otherwise you might as well add all the other managed symbols `(e.g. S_MANPROC)`
s/if we're not supporting code/if we're not supporting **managed** code/


https://reviews.llvm.org/D34898