[PATCH] D34906: [llvm-pdbutil] Output the symbol offset when dumping symbols

[Zachary Turner via Phabricator via llvm-commits]

zturner created this revision.
Herald added a subscriber: hiraditya.

  Type records have a unique type index, but symbol records do
  not.  Instead, symbol records refer to other symbol records
  by referencing their offset in the symbol stream.  In a sense
  this is the analogue of the TypeIndex, but we are not printing
  it in the dumper.  Printing it not only gives us more useful
  information when manually investigating the contents of a PDB,
  but also allows us to write better tests by enabling us to
  verify that fields that reference other symbol records do
  so correctly.


https://reviews.llvm.org/D34906

Files:
  lld/test/COFF/pdb-comdat.test
  lld/test/COFF/pdb-global-gc.yaml
  lld/test/COFF/pdb-import-gc.yaml
  lld/test/COFF/pdb-safeseh.yaml
  lld/test/COFF/pdb-secrel-absolute.yaml
  lld/test/COFF/pdb-symbol-types.yaml
  llvm/include/llvm/DebugInfo/CodeView/CVSymbolVisitor.h
  llvm/include/llvm/DebugInfo/CodeView/SymbolDeserializer.h
  llvm/include/llvm/DebugInfo/CodeView/SymbolVisitorCallbackPipeline.h
  llvm/include/llvm/DebugInfo/CodeView/SymbolVisitorCallbacks.h
  llvm/lib/DebugInfo/CodeView/CVSymbolVisitor.cpp
  llvm/test/DebugInfo/PDB/pdbdump-headers.test
  llvm/tools/llvm-pdbutil/DumpOutputStyle.cpp
  llvm/tools/llvm-pdbutil/MinimalSymbolDumper.cpp
  llvm/tools/llvm-pdbutil/MinimalSymbolDumper.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34906.104924.patch
Type: text/x-patch
Size: 55678 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170630/b3469e43/attachment.bin>