[PATCH] D34875: ARM: Report error for invalid use of AAPCS_VFP calling convention

Tim Northover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 30 10:16:18 PDT 2017


t.p.northover added a comment.

> I think that they do, because report_fatal_error() causes compilation to terminate so the subsequent tests don't generate a message which can be checked.

Ah yes. And that's also a really big indicator for why this should be handled in Clang. All you know from this is that at least one function, somewhere in your file (or codebase if doing LTO) has an aapcs_vfp attribute.

I get that silently doing SoftFP isn't great either so I'm not completely opposed to this change, I just think it's a pretty half-baked solution to the actual user-facing problem.


https://reviews.llvm.org/D34875





More information about the llvm-commits mailing list