[PATCH] D34895: Add sample PGO support to ThinLTO new pass manager.
Teresa Johnson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 30 10:08:52 PDT 2017
tejohnson added a comment.
This looks fine to me. One minor suggestion below.
================
Comment at: lib/Passes/PassBuilder.cpp:762
// can.
- MPM.addPass(buildModuleSimplificationPipeline(Level, DebugLogging));
+ MPM.addPass(buildModuleSimplificationPipeline(Level, DebugLogging, true));
----------------
Suggest prefixing the new bool parameter with "/*PrepareForThinLTO=*/" to make it more obvious.
https://reviews.llvm.org/D34895
More information about the llvm-commits
mailing list