[llvm] r306839 - [Dominators] Do not perform expensive checks by default. Fix PR33656.

[Jakub Kuderski via llvm-commits]

Author: kuhar
Date: Fri Jun 30 09:33:04 2017
New Revision: 306839

URL: http://llvm.org/viewvc/llvm-project?rev=306839&view=rev
Log:
[Dominators] Do not perform expensive checks by default. Fix PR33656.

Summary:
Some transforms assume that DT.verifyDomInfo() is not expensive and call it even when ENABLE_EXPENSIVE_CHECKS is not set.
This patch disables expensive Dominator Tree verification (reachability, parent property, sibling property) to fix
[[ https://bugs.llvm.org/show_bug.cgi?id=33656 | PR33656 ]].

Note that this is only a temporary fix.

Reviewers: dberlin, chapuni, kparzysz, grosser

Reviewed By: dberlin

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D34894

Modified:
    llvm/trunk/lib/IR/Dominators.cpp

Modified: llvm/trunk/lib/IR/Dominators.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/Dominators.cpp?rev=306839&r1=306838&r2=306839&view=diff
==============================================================================
--- llvm/trunk/lib/IR/Dominators.cpp (original)
+++ llvm/trunk/lib/IR/Dominators.cpp Fri Jun 30 09:33:04 2017
@@ -292,7 +292,8 @@ bool DominatorTree::isReachableFromEntry
 }
 
 void DominatorTree::verifyDomTree() const {
-  if (!verify()) {
+  // Perform the expensive checks only when VerifyDomInfo is set.
+  if (VerifyDomInfo && !verify()) {
     errs() << "\n~~~~~~~~~~~\n\t\tDomTree verification failed!\n~~~~~~~~~~~\n";
     print(errs());
     abort();