[PATCH] D33320: [SLP] Improve comments and naming of functions/variables/members, NFC.

[Anna Thomas via Phabricator via llvm-commits]

anna added a comment.

In https://reviews.llvm.org/D33320#796821, @ABataev wrote:

> I'm working on the patch that stops vectorization if the parent basic block of the instruction is not BB or the instruction was processed already, but it's quite hard to add a test for this change. I can publish it as NFC, because we just limiting the number of analyzed instructions if this is acceptable.


Thanks Alexey. That should fix the current regressions we are seeing. Could you please add me as a reviewer to the patch?

The second concern I have (as mentioned in above comment) is that with  https://reviews.llvm.org/D25517, we are increasing the complexity of `tryToVectorizeHorReductionOrInstOperands` from a single node being processed to an exponential number of nodes (2^12). Is this a correct analysis?

It may not be an issue in practice once we limit to the current basic block (the fix you're working on). However, this function is called for every instruction in the IR  as part of `vectorizeChainsInBlock`, so as the basic block size increases, we may see a compile time impact.


Repository:
  rL LLVM

https://reviews.llvm.org/D33320