[PATCH] D34685: Mark a number of x86 only tests to require x86

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 30 09:00:10 PDT 2017


ruiu added a comment.

> I'll update the patch. But I'm still concerned that needing to add "REQUIRES: x86" is going to be an ongoing maintenance for us as new tests are added.

We should start adding "REQUIRES: x86" to new tests from now on.

> Also as it currently stands, I can't see an easy way to distinguish between generic tests and actual x86 tests.

You can distinguish by filename, as target-specific tests start with target name.


https://reviews.llvm.org/D34685





More information about the llvm-commits mailing list