[PATCH] D34885: Add element atomic memset intrinsic

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

Codewise, this looks fine and clearly implements the semantics you document.  However, I wondering if those are the most useful semantics.  Once we answer the design question below, if we still want to go in this direction the patch LGTM.

This can be used to represent any pattern memset currently can.  In particular it does handle larger elements with repeating bytewise values.  It does not full cover the Arrays.fill case though because a value such as "i32 15" can't be represented.  I could see an argument in favour of handling that case entirely separately or all of it in a single family of intrinsics.  What do you think?


https://reviews.llvm.org/D34885