[PATCH] D34685: Mark a number of x86 only tests to require x86

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

In https://reviews.llvm.org/D34685#795512, @ruiu wrote:

> Yes, that's what I meant. It's not ideal, but if you want to write tests that don't depend on target, what target would you choose?


LLVM also has lots of tests that are generic in principle, but end up depending on a particular target for practical reasons.  However, the project does not require people to include the X86 target (or ARM target, another favorite for "generic" tests) before they can run tests at all.  The project relies on the many people who *do* have those targets enabled, plus bots, to guarantee coverage.  And, the ought-to-be-generic tests end up in target-specific directories, where they don't get in the way of people whose work either doesn't depend on that target or requires that they not have that target enabled.  As one recent example, r295384 added a "generic" test that had to be moved to an X86 specific directory in r295389, for exactly this reason.

The people who are proposing this change do not, for whatever reason, want to include the x86 target.  I don't think the LLD project should force them to include it.  I know I don't personally contribute meaningfully to the LLD project, but others in my company do, and as a designated merge guru I need to keep them happy.


https://reviews.llvm.org/D34685