[PATCH] D34758: [YAML] - Teach yaml2obj/obj2yaml to work with numeric relocation values.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 30 03:31:32 PDT 2017


This revision was automatically updated to reflect the committed changes.
Closed by commit rL306814: [YAML] - Teach yaml2obj/obj2yaml to work with numeric relocation values. (authored by grimar).

Changed prior to commit:
  https://reviews.llvm.org/D34758?vs=104657&id=104838#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D34758

Files:
  llvm/trunk/lib/ObjectYAML/ELFYAML.cpp
  llvm/trunk/test/Object/X86/yaml-elf-x86-rel-broken.yaml


Index: llvm/trunk/lib/ObjectYAML/ELFYAML.cpp
===================================================================
--- llvm/trunk/lib/ObjectYAML/ELFYAML.cpp
+++ llvm/trunk/lib/ObjectYAML/ELFYAML.cpp
@@ -542,6 +542,7 @@
     llvm_unreachable("Unsupported architecture");
   }
 #undef ELF_RELOC
+  IO.enumFallback<Hex32>(Value);
 }
 
 void ScalarEnumerationTraits<ELFYAML::MIPS_AFL_REG>::enumeration(
Index: llvm/trunk/test/Object/X86/yaml-elf-x86-rel-broken.yaml
===================================================================
--- llvm/trunk/test/Object/X86/yaml-elf-x86-rel-broken.yaml
+++ llvm/trunk/test/Object/X86/yaml-elf-x86-rel-broken.yaml
@@ -0,0 +1,29 @@
+# RUN: yaml2obj %s > %t
+# RUN: obj2yaml %t | FileCheck %s
+
+# CHECK:       Relocations:
+# CHECK-NEXT:    - Offset:
+# CHECK-NEXT:      Symbol:
+# CHECK-NEXT:      Type: 0x000000FF
+
+!ELF
+FileHeader:
+  Class:           ELFCLASS32
+  Data:            ELFDATA2LSB
+  Type:            ET_REL
+  Machine:         EM_386
+Sections:
+  - Type:            SHT_PROGBITS
+    Name:            .text
+    Flags:           [ SHF_ALLOC, SHF_EXECINSTR ]
+    AddressAlign:    0x04
+    Content:         0000000000000000
+  - Type:            SHT_REL
+    Name:            .rel.text
+    Link:            .symtab
+    Info:            .text
+    AddressAlign:    0x04
+    Relocations:
+      - Offset:          0
+        Symbol:          main
+        Type:            0xFF


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34758.104838.patch
Type: text/x-patch
Size: 1433 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170630/7f659f74/attachment.bin>


More information about the llvm-commits mailing list