[PATCH] D34864: [ORE] Unify spelling as "diagnostics hotness"

[Brian Gesiak via Phabricator via llvm-commits]

modocache created this revision.
Herald added a subscriber: mehdi_amini.

To enable profile hotness information in diagnostics output, Clang takes
the option `-fdiagnostics-show-hotness` -- that's "diagnostics", with an
"s" at the end. Clang also defines `CodeGenOptions::DiagnosticsWithHotness`.

LLVM, on the other hand, defines
`LLVMContext::getDiagnosticHotnessRequested` -- that's "diagnostic", not
"diagnostics". It's a small difference, but it's confusing, typo-inducing, and
frustrating.

Add a new method with the spelling "diagnostics", and "deprecate" the
old spelling.


https://reviews.llvm.org/D34864

Files:
  include/llvm/Analysis/OptimizationDiagnosticInfo.h
  include/llvm/CodeGen/MachineOptimizationRemarkEmitter.h
  include/llvm/IR/LLVMContext.h
  lib/Analysis/OptimizationDiagnosticInfo.cpp
  lib/CodeGen/MachineOptimizationRemarkEmitter.cpp
  lib/IR/LLVMContext.cpp
  lib/IR/LLVMContextImpl.h
  lib/LTO/LTO.cpp
  tools/llc/llc.cpp
  tools/opt/opt.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34864.104818.patch
Type: text/x-patch
Size: 7576 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170630/8f9a961a/attachment.bin>