[PATCH] D27620: [Assembler] Report multiple near misses for invalid instructions
Eric Christopher via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 29 17:18:09 PDT 2017
echristo added a comment.
Hi Oliver!
I'm sorry for the delay, that said I'd also like to see a lot more commenting through here along with how we expect this API/data structures to work. It's hard to review this because I'm not sure how it's going to be used ultimately.
I don't see any noticeable problems, but I'd really like to see how this is going to be used (and have that commented in the source) before putting this in.
Thanks!
-eric
Repository:
rL LLVM
https://reviews.llvm.org/D27620
More information about the llvm-commits
mailing list