[PATCH] D34792: [lit] Remove dead code not referenced in the LLVM SVN repo.

[David L. Jones via Phabricator via llvm-commits]

dlj added a comment.

In https://reviews.llvm.org/D34792#795937, @mzolotukhin wrote:

> We're seeing more issues (I think they are unrelated to the `FileBasedTest` issue mentioned before).
>
> [1] is one example of the failure, the error is:
>
>   lit.py: /Users/buildslave/jenkins/sharedspace/phase1 at 2/llvm/utils/lit/lit/TestingConfig.py:101: fatal: unable to parse config file '/Users/buildslave/jenkins/sharedspace/phase1 at 2/llvm/projects/libcxx/test/lit.cfg', traceback: Traceback (most recent call last):
>     File "/Users/buildslave/jenkins/sharedspace/phase1 at 2/llvm/utils/lit/lit/TestingConfig.py", line 88, in load_from_path
>       exec(compile(data, path, 'exec'), cfg_globals, None)
>     File "/Users/buildslave/jenkins/sharedspace/phase1 at 2/llvm/projects/libcxx/test/lit.cfg", line 52, in <module>
>       configuration.configure()
>     File "/Users/buildslave/jenkins/sharedspace/phase1 at 2/llvm/projects/libcxx/utils/libcxx/test/config.py", line 129, in configure
>       self.configure_triple()
>     File "/Users/buildslave/jenkins/sharedspace/phase1 at 2/llvm/projects/libcxx/utils/libcxx/test/config.py", line 1073, in configure_triple
>       self.use_deployment = not self.use_target and self.can_use_deployment()
>     File "/Users/buildslave/jenkins/sharedspace/phase1 at 2/llvm/projects/libcxx/utils/libcxx/test/config.py", line 1059, in can_use_deployment
>       if not self.target_info.is_host_macosx():
>     File "/Users/buildslave/jenkins/sharedspace/phase1 at 2/llvm/projects/libcxx/utils/libcxx/test/target_info.py", line 76, in is_host_macosx
>       name = lit.util.capture(['sw_vers', '-productName']).strip()
>   AttributeError: 'module' object has no attribute 'capture'
>
>
> Any ideas on how to fix it?
>
> [1]: http://green.lab.llvm.org/green/job/clang-stage1-configure-RA_check/32959/consoleFull#-42777206a1ca8a51-895e-46c6-af87-ce24fa4cd561


Indeed, that is different... that's a very surprising place for a dependency on lit. I don't think the utility is needed at all here.

This patch should fix it:
https://reviews.llvm.org/D34841

However, I don't believe I have access to a testing environment that can validate the forward fix (or a revert, for that matter). If you want, you can patch it and try it. Otherwise, let me know if I should go ahead and submit with crossed fingers.


Repository:
  rL LLVM

https://reviews.llvm.org/D34792