[PATCH] D34576: [ConstantHoisting] Avoid hoisting constants in GEPs that index into a struct type.

[Pirama Arumuga Nainar via Phabricator via llvm-commits]

pirama added a comment.

In https://reviews.llvm.org/D34576#795833, @efriedma wrote:

> The new code here seems to overlap with llvm::canReplaceOperandWithVariable.  Can we unify them?


Unifying with canReplaceOperandWithVariable can make the code simpler.  However, we'd also end up iterating the GEP once for each operand.  I couldn't find any limit on the number of indices in a GEP, but would a quadratic iteration of the indices be reasonable?


https://reviews.llvm.org/D34576