[PATCH] D34789: Copy arguments passed by value into explicit allocas for ASan

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added a comment.

In https://reviews.llvm.org/D34789#795883, @vitalybuka wrote:

> In https://reviews.llvm.org/D34789#795718, @eugenis wrote:
>
> > Right, but then why don't we add 5 new allocas in each function, poison them and never use them. Access to those would also be a bug.
>
>
> This is not the same. We already have original space allocate on the stack, and we know that this should not be accessed.
>  We can investigate usefulness of this later.


You are right. Still, this is unlikely to ever catch anything, and it increases code size and adds some complexity to the instrumentation pass. I don't mind either way.


https://reviews.llvm.org/D34789