[PATCH] D34830: [lit, test-suite] Fix a reference to FileBasedTest that I missed earlier.

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 29 13:49:19 PDT 2017


MatzeB added a comment.

In https://reviews.llvm.org/D34830#795804, @dlj wrote:

> In https://reviews.llvm.org/D34830#795765, @MatzeB wrote:
>
> > What happens when the user is using the lit from "pip install lit" instead of the one coming with llvm?
>
>
> That should be fine. ShTest has the same semantics before and after, so importing the old or the new version of ShTest will work.
>
> Now, if they were using an old version of test-suite and the new version of lit, the answer would be different.


Ok, that's fine. Thanks for the fix.


Repository:
  rL LLVM

https://reviews.llvm.org/D34830





More information about the llvm-commits mailing list