[PATCH] D34584: Introduce new JSON import format

[Matthias Braun via Phabricator via llvm-commits]

MatzeB marked 6 inline comments as done.
MatzeB added a comment.

Thanks for the review!



================
Comment at: lnt/testing/__init__.py:40
         self.tests = list(tests)
-        self.report_version = current_version
+        self.report_version = '1'
         self.check()
----------------
kristof.beyls wrote:
> I'm not sure, as I don't understand this code well, but there's a chance this should now be renamed to self.format_version instead of self.report_version?
This is the version used for the reports produced by things like `lnt runtest`. Those still produce the old format. Which I guess for now is a feature as we can still submit to old servers for a while and can do this switch separately.


================
Comment at: lnt/testing/__init__.py:109-112
         if '__report_version__' in self.info:
             raise ValueError("'__report_version__' key is reserved")
-        self.info['__report_version__'] = str(current_version)
+        # TODO: Convert to version 2
+        self.info['__report_version__'] = '1'
----------------
kristof.beyls wrote:
> I guess the conversion of the Run class to follow format_version 2, rather than 1 will fit more naturally with one of the follow-up patches? Or as a stand-alone technical-debt-removal patch?
Yep.


Repository:
  rL LLVM

https://reviews.llvm.org/D34584