[PATCH] D34668: llvm-nm: Add suport for symbol demangling (-C/--demangle)

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: llvm/trunk/tools/llvm-nm/llvm-nm.cpp:667
 
+static Optional<std::string> demangle(StringRef Name, bool StripUnderscore) {
+  if (StripUnderscore && Name.size() > 0 && Name[0] == '_')
----------------
This may be a dumb question, but does MachO use the Itanium mangling scheme?

Does it use both "__Z" and "_Z" as prefixes?


================
Comment at: llvm/trunk/tools/llvm-nm/llvm-nm.cpp:668
+static Optional<std::string> demangle(StringRef Name, bool StripUnderscore) {
+  if (StripUnderscore && Name.size() > 0 && Name[0] == '_')
+    Name = Name.substr(1);
----------------
You can use `startswith`


Repository:
  rL LLVM

https://reviews.llvm.org/D34668