[llvm] r306608 - Revert "Make OrderedInstructions and OrderedBasicBlock use AssertingVH, to try and catch mistakes"

[Xin Tong via llvm-commits]

On Wed, Jun 28, 2017 at 4:15 PM, Davide Italiano <davide at freebsd.org> wrote:
> On Wed, Jun 28, 2017 at 3:35 PM, Xin Tong via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> Author: trentxintong
>> Date: Wed Jun 28 15:35:54 2017
>> New Revision: 306608
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=306608&view=rev
>> Log:
>> Revert "Make OrderedInstructions and OrderedBasicBlock use AssertingVH, to try and catch mistakes"
>>
>> This reverts commit 50ec560f05dcb8a1be18be442660d0305bc7de25.
>>
>> It catches some bug in NewGVN it seems. I am in middle of something and will not be able to investigate
>> Revert for now.
>>
>
> Good :) I'm in the middle of something too but once I'll get a chance
> (probably Friday) I'll apply locally and see what's the issue.
>
> Thanks,
>
> --
> Davide

I am looking at this one. The problem is NewGVN uses PredicateInfo
which uses OrderedInstructions and it does not
invalidateOrderedBasicBlock when it deletes instructions.

-Xin


-- 
Software Engineer - Compiler Toolchain
Employee of Facebook Inc.