[PATCH] D34735: [opt-viewer] Add progress indicators (PR33522)
Brian Gesiak via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 29 10:22:29 PDT 2017
modocache added a comment.
I had seen tqdm, but:
1. I wasn't sure what you thought about taking on another dependency, so I erred on the safe side of no additional external dependencies
2. Just printing "N of 1197" is good enough for me, it lets me get some feedback on whether the script is still working hard or whether it's stuck
Up to you, though! Happy to rewrite this with tqdm. My personal preference would be to merge as-is, and if someone wants to make a nicer-looking progress bar they're free to use tqdm.
https://reviews.llvm.org/D34735
More information about the llvm-commits
mailing list