[PATCH] D34596: [X86]: Adding a priorty selection guided-src for pre-RA instruction scheduling.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

I'll leave the scheduler part of the review to someone who understands it better!



================
Comment at: include/llvm/CodeGen/SchedulerRegistry.h:64
 
 /// createBURRListDAGScheduler - This creates a bottom up list scheduler that
 /// schedules nodes in source code order when possible.
----------------
Fix this comment for createGuidedSrcListDAGScheduler


================
Comment at: lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp:2602
+       );
+       if (SchedUnit != Sequence.end()) Weight += 10;
+     }
----------------
(style) Put Weight += 10; on a newline.


================
Comment at: test/CodeGen/X86/guided_sched.ll:2
+; NOTE: Both functions must emit same instruction schedule with -guided-src 
+; RUN: llc -pre-RA-sched=guided-src -mtriple=x86_64-unknown-linux-gnu -mattr=avx2 -mcpu=skx < %s | FileCheck %s 
+
----------------
Drop the avx2/skx requirements - you should be able to just use -mattr=+lzcnt


https://reviews.llvm.org/D34596