[PATCH] D34647: [opt-viewer] Python 3 support in opt-viewer.py

[Adam Nemet via Phabricator via llvm-commits]

anemet added inline comments.


================
Comment at: utils/opt-viewer/opt-viewer.py:193-195
+        sorted_remarks = sorted(optrecord.itervalues(all_remarks), key=lambda r: (r.Hotness, r.File, r.Line, r.Column), reverse=True)
     else:
+        sorted_remarks = sorted(optrecord.itervalues(all_remarks), key=lambda r: (r.File, r.Line, r.Column))
----------------
The idea for sticking r.__dict__ at the end was to have a deterministic index page.  This allows diffing the before and after html directories to make sure a change is in fact NFC.

Is __dict__ no longer available in Python3?



https://reviews.llvm.org/D34647