[PATCH] D33680: [ELF] - Resolve references properly when using .symver directive
George Rimar via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 29 05:26:59 PDT 2017
>> + for (Symbol *Sym : SymVector) {
>> + SymbolBody *Body = Sym->body();
>> + bool IsDefault = isDefaultVersion(Body);
>> + Body->parseSymbolVersion();
>> +
>> + if (!IsDefault)
>> + continue;
>
>I think you can omit the IsDefault variable:
>
>if (!isDefaultVersion(Body))
> continue;
>
>Cheers,
>Rafael
I think no :( Because parseSymbolVersion() drops the version from name. So I
introduced this flag intentionally to remember if version is default before
name truncation happens.
George.
More information about the llvm-commits
mailing list