[PATCH] D34787: Delete comparison with GlobalOffsetTable.

Mark Kettenis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 29 03:08:16 PDT 2017


kettenis added a comment.

It is not completely obvious to me that this is indeed equivalent as the semantics of R_GOTONLY_PC, but it seems to work. I think it works because we define _GLOBAL_OFFSET_TABLE_ as hidden. This no longer forces the creation of an empty GOT but I think the use of these relocation implies that there is a non-empty GOT already.

Benefit of your change as that this will allow us to make _GLOBAL_OFFSET_TABLE_ point somewhere in the middle of the GOT as suggested by the ABI. So let's keep this for now.


https://reviews.llvm.org/D34787





More information about the llvm-commits mailing list