[PATCH] D34077: DAGCombine: Combine BUILD_VECTOR to TRUNCATE

Zvi Rackover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 29 01:09:42 PDT 2017


zvi updated this revision to Diff 104604.
zvi added a comment.

Rebase on ToT and update test/CodeGen/X86/shuffle-vs-trunc-512.ll which was recently added and was affected by this change.
To continue the discussion with @wolfgangp in https://reviews.llvm.org/D34069, IMO we should consider removing this test if it does not cover the defect it originally intended to, but i don't have any strong objection to keep it with the updated checks.


https://reviews.llvm.org/D34077

Files:
  include/llvm/Target/TargetLowering.h
  lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  lib/Target/X86/X86ISelLowering.h
  test/CodeGen/X86/shuffle-vs-trunc-256.ll
  test/CodeGen/X86/shuffle-vs-trunc-512.ll
  test/CodeGen/X86/vector-truncate-combine.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34077.104604.patch
Type: text/x-patch
Size: 53928 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170629/3f8dc813/attachment.bin>


More information about the llvm-commits mailing list