[PATCH] D32272: [XRay] Add Google Benchmark library + initial XRay benchmarks

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added inline comments.


================
Comment at: CMakeLists.txt:187-189
     if(NOT ${subdir} STREQUAL ${CMAKE_CURRENT_SOURCE_DIR}/tools AND
+       NOT ${subdir} STREQUAL ${CMAKE_CURRENT_SOURCE_DIR}/libs AND
        NOT ${subdir} STREQUAL ${CMAKE_CURRENT_SOURCE_DIR}/CTMark)
----------------
Make sure you rebase to ToT! This part looks slightly different since a few weeks ago.


================
Comment at: MicroBenchmarks/XRay/CMakeLists.txt:1
+if(DEFINED ENABLE_XRAY_MICROBENCHMARKS)
+  check_cxx_compiler_flag(-fxray-instrument COMPILER_HAS_FXRAY_INSTRUMENT)
----------------
This has to be called `TEST_SUITE_ENABLE_XRAY_MICROBENCHMARKS` or similar. The TEST_SUITE_ prefix is necessary for people who run the test-suite as part of a normal llvm build (I think there is still some people left doing that). Without the prefix the option will not end up being set for the test-suite in the combined build.

Alternatively you could just not add an option and exclude `MicroBenchmarks` from the default subdirecty list (same way you already excluded the libs directory). People can then use
`-DTEST_SUITE_SUBDIRS="Microbenchmars"` or `-DTEST_SUITE_SUBDIRS="SingleSource;MultiSource;Microbenchmarks"` to select what parts of the testsuite they want to run.


https://reviews.llvm.org/D32272