[PATCH] D34793: [lit] Fix some convoluted logic around Unicode encoding, and de-duplicate across modules that used it.

David L. Jones via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 18:03:28 PDT 2017


dlj added inline comments.


================
Comment at: utils/lit/lit/util.py:51
+    # The last type we might expect is the Python2 'unicode' type. There is no
+    # 'uncode' type in Python3 (all the Python3 cases were already handled). In
+    # order to get a 'str' object, we need to encode the 'unicode' object.
----------------
modocache wrote:
> Typo, I think: "uncode" should be "unicode".
Ah, good catch. You are correct.


https://reviews.llvm.org/D34793





More information about the llvm-commits mailing list