[PATCH] D34793: [lit] Fix some convoluted logic around Unicode encoding, and de-duplicate across modules that used it.

Brian Gesiak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 17:56:00 PDT 2017


modocache accepted this revision.
modocache added a comment.
This revision is now accepted and ready to land.

LGTM! Thanks for all the cleanups!



================
Comment at: utils/lit/lit/util.py:51
+    # The last type we might expect is the Python2 'unicode' type. There is no
+    # 'uncode' type in Python3 (all the Python3 cases were already handled). In
+    # order to get a 'str' object, we need to encode the 'unicode' object.
----------------
Typo, I think: "uncode" should be "unicode".


https://reviews.llvm.org/D34793





More information about the llvm-commits mailing list