[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

In https://reviews.llvm.org/D34728#794508, @timshen wrote:

> Added -fexperimental-new-pass-manager=off/on/debug for printing debug information.
>
> Added a Clang test.
>
> Do tell if you want me to split this patch. I didn't, becuase then I don't have to write a test for each of them. :)


I think they should be split into two patches, one for the option change and one for the thinLTO pipeline fixes. You could just put the new lto-newpm-pipeline.c test in with the option changes patch and commit it right after the thinlto pipeline fixes (or do it first and modify that test to add the thinlto passes when the pipeline fix goes in).

LGTM, but please wait to see if Chandler has any more comments.



================
Comment at: clang/include/clang/Frontend/CodeGenOptions.h:92
 
+  enum NewPassManagerKind {
+    NewPM_Off,
----------------
Document


https://reviews.llvm.org/D34728