[PATCH] D34765: [DWARF] [NFC] Move a couple of member functions to DWARFUnit (baseclass) from DWARFCompileUnit (derived class)

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp added a comment.

In https://reviews.llvm.org/D34765#794069, @dblaikie wrote:

> This is for DW_AT_str_offsets_base in a type unit?


Yes.

> Is the delta version needed? (is that modifying the existing use in split DWARF to now require a tag for str_offsets_base when none was needed before) Or only the addSectionLabel?

The delta version avoids generating relocations, which we can't have for split DWARF, so for version >=5 the plan is to generate the str_offsets_base tag using addSectionLabel() for when we can use relocations and addSectionDelta() for when we can't (such as split DWARF, or Mach-O).


https://reviews.llvm.org/D34765