[PATCH] D34764: Introduce FileEdit utility

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 13:58:47 PDT 2017


rnk added a subscriber: rsmith.
rnk added a comment.

In https://reviews.llvm.org/D34764#794154, @chandlerc wrote:

> I'm not as fussed as you seem to be about having separate files... but OK.


Fair. :)

It reminds me of how every compiler person I know has different ways of feeding small test cases to the compiler. On the one hand, you have @rsmith who does `echo 'int evil_test() {...}' | clang -cc1 -x c++ - ...` in zsh, and then you have me perpetually compiling `t.cpp`, and still other people create unique directories for every interesting test case they come across. I can't say what's right, but personally, not having to chase a filepath into %S/Inputs is one less step that I need to take to understand a test. For some people, that's not even having to think about giving filenames to their tests because they pipe them directly to the compiler.


https://reviews.llvm.org/D34764





More information about the llvm-commits mailing list