[PATCH] D34775: [lit] Remove dead code (not referenced anywhere), and clarify some function names.

David L. Jones via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 13:53:19 PDT 2017


dlj created this revision.
Herald added a subscriber: sanjoy.
Herald added a reviewer: modocache.

The dead code seems to be unreferenced, according to textual search across the
LLVM SVN repo.

The clarification part of this change alters the name of a module-level function
so that it is different from the name of the class-methods that call it.
Currently, there are no erroneous references, but stylistically (c.f. PEP-8),
internal "helper" functions should generally be named accordingly by prepending
an underscore. (I also chose to add '_impl', which isn't necessary, but helps me
at least to mentally disambiguate the interface and implementation functions.)


https://reviews.llvm.org/D34775

Files:
  utils/lit/lit/run.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34775.104500.patch
Type: text/x-patch
Size: 8162 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170628/4124fed6/attachment.bin>


More information about the llvm-commits mailing list